987596 - B2G NFC: Marionette tests for onpeerready

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

We need a marionette test case for testing onpeerready.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch

Comment 2

[Dimi Lee [:dimi]]

Comment on attachment 8412527 [details] [diff] [review]
Patch

Review of attachment 8412527 [details] [diff] [review]:
-----------------------------------------------------------------

Pass local marionette test case.

::: dom/nfc/tests/marionette/test_nfc_peer.js
@@ +5,5 @@
> +MARIONETTE_HEAD_JS = 'head.js';
> +
> +let MANIFEST_URL = "app://system.gaiamobile.org/manifest.webapp";
> +let Promise =
> +  SpecialPowers.Cu.import("resource://gre/modules/Promise.jsm").Promise;

I think we could move Promise to head.js because more and more testcases will use it in the future.

@@ +12,5 @@
> +function testPeerReady(evt) {
> +  log("testPeerReady called");
> +  let peer = nfc.getNFCPeer(evt.detail);
> +  ok(peer instanceof MozNFCPeer, "Should get a NFCPeer object.");
> +  runNextTest();

Should we call toggleNFC(false, runNextTest);  ?

@@ +29,5 @@
> +  }
> +
> +  request.onerror = function () {
> +    ok(false, "checkP2PRegistration failed.");
> +    runNextTest();

ditto.

@@ +38,5 @@
> +  let deferred = Promise.defer();
> +  let cmd = "nfc ntf rf_intf_activated " + re;
> +
> +  emulator.run(cmd, function(result) {
> +    is(result.pop(), "OK", "check activation of RE0");

We should use is(result.pop(), "OK", "check activation of RE" + re);
Please also help modify test_nfc_manager_tech_discovered.js, thanks

@@ +56,5 @@
> +  });
> +}
> +
> +let tests = [
> +  testActivateRE0

Naming of this testcase seems not match what we are going to test ?

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch v2.

addressed Dimi's comments.

Comment 4

[Dimi Lee [:dimi]]

Comment on attachment 8413622 [details] [diff] [review]
Patch v2.

Review of attachment 8413622 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for code refine, could you also help remove import Promise in test_nfc_manager_tech_discovered.js.
r+ with nits fixed

::: dom/nfc/tests/marionette/test_nfc_manager_tech_discovered.js
@@ +23,5 @@
>    let deferred = Promise.defer();
>    let cmd = 'nfc ntf rf_intf_activated ' + re;
>  
>    emulator.run(cmd, function(result) {
> +    is(result.pop(), 'OK', 'check activation of RE0' + re);

Nits, Remove 0  from RE0

::: dom/nfc/tests/marionette/test_nfc_peer.js
@@ +39,5 @@
> +  let deferred = Promise.defer();
> +  let cmd = "nfc ntf rf_intf_activated " + re;
> +
> +  emulator.run(cmd, function(result) {
> +    is(result.pop(), "OK", "check activation of RE0" + re);

Nits. Remove 0 from RE0

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch v3.

Comment 6

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8413635 [details] [diff] [review]
Patch v3.

Review of attachment 8413635 [details] [diff] [review]:
-----------------------------------------------------------------

Addressed Comment 4.
Also move declaration of nfc into head.js. r? for this change.

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/d5d2904ed31c

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d5d2904ed31c